feat: add cpu/cuda config for prompt guard #2194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously prompt guard was hard coded to require cuda which prevented it from being used on an instance without a cuda support. This PR allows prompt guard to be configured to use either cpu or cuda. Signed-off-by: Michael Dawson <[email protected]>
mhdawson
requested review from
ashwinb,
yanxi0830,
hardikjshah,
raghotham,
ehhuang,
terrytangyuan and
leseb
as code owners
facebook-github-bot
added
the
CLA Signed
ashwinb
reviewed
May 16, 2025
| @@ -75,7 +75,7 @@ def __init__( | |||
| self.temperature = temperature | |||
| self.threshold = threshold | |||
|
|
|||
| self.device = "cuda" | |||
| self.device = self.config.guard_execution_type | |||
There was a problem hiding this comment.
can we just check if cuda is available and use that otherwise use CPU? no need for a specific configuration like this to be added.
There was a problem hiding this comment.
@ashwinb I'll take a look at that and update
ashwinb
requested changes
May 19, 2025
Signed-off-by: Michael Dawson <[email protected]>
|
@ashwinb updated based on your suggestion. Thanks for taking the time to review my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously prompt guard was hard coded to require cuda which prevented it from being used on an instance without a cuda support.
This PR allows prompt guard to be configured to use either cpu or cuda.
Closes #2133
Test Plan (Edited after incorporating suggestion)
started stack configured with prompt guard as follows on a system without a GPU
and validated prompt guard could be used through the APIs
validated on a system with a gpu (but without llama stack) that the python selecting between cpu and cuda support returned the right value when a cuda device was available.
ran the unit tests as per - https://github.com/meta-llama/llama-stack/blob/main/tests/unit/README.md